Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to vertically centre nodes in IPPM [MVP] #376

Merged
merged 9 commits into from
Sep 27, 2024
Merged

Conversation

caiw
Copy link
Member

@caiw caiw commented Sep 21, 2024

Fixes #363

  • Can now specify y_ordinate_method="centered" as an argument to IPPMBuilder().
    • "progressive" reverts to old behaviour and is the default.
  • If "centered" is specified, also supply a list-of-lists describing the serial sequence of parallel steps.
  • If "centered" is specified,f unctions within each serial step are vertically centred among each other.
  • Optionally also specify avoid_collinearity=True to avoid cases where CV would induce dots or lines to overlap making graph structure impossible to visually read (as in the two examples in the demo notebook).

Also does

  • Automatically scales arrowheads depending on the size of the graph.

This is a minimum-viable product

Example before/after

image
image

@caiw caiw added 💪 enhancement New feature or request 📈 plotting functionality Any issues related to plotting IPPM generation labels Sep 21, 2024
@caiw caiw self-assigned this Sep 21, 2024
@caiw caiw linked an issue Sep 21, 2024 that may be closed by this pull request
@caiw caiw requested a review from neukym September 27, 2024 15:22
@caiw caiw marked this pull request as ready for review September 27, 2024 15:22
# Conflicts:
#	demos/demo_ippm.ipynb
@caiw caiw changed the title Option to vertically centre nodes in IPPM Option to vertically centre nodes in IPPM [MVP] Sep 27, 2024
Copy link
Member

@neukym neukym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great...! Approved.

@neukym neukym merged commit 188002b into main Sep 27, 2024
3 checks passed
@neukym neukym deleted the 363-ippm-y-coordinate branch September 27, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request IPPM generation 📈 plotting functionality Any issues related to plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPPM: Adds better y coordinate
2 participants