-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to vertically centre nodes in IPPM [MVP] #376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caiw
added
💪 enhancement
New feature or request
📈 plotting functionality
Any issues related to plotting
IPPM generation
labels
Sep 21, 2024
caiw
force-pushed
the
363-ippm-y-coordinate
branch
from
September 21, 2024 05:45
5ad6642
to
bee48b9
Compare
caiw
force-pushed
the
363-ippm-y-coordinate
branch
from
September 27, 2024 14:56
b2d5da8
to
a420121
Compare
# Conflicts: # demos/demo_ippm.ipynb
caiw
changed the title
Option to vertically centre nodes in IPPM
Option to vertically centre nodes in IPPM [MVP]
Sep 27, 2024
neukym
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great...! Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💪 enhancement
New feature or request
IPPM generation
📈 plotting functionality
Any issues related to plotting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #363
y_ordinate_method="centered"
as an argument toIPPMBuilder()
."progressive"
reverts to old behaviour and is the default."centered"
is specified, also supply a list-of-lists describing the serial sequence of parallel steps."centered"
is specified,f unctions within each serial step are vertically centred among each other.avoid_collinearity=True
to avoid cases where CV would induce dots or lines to overlap making graph structure impossible to visually read (as in the two examples in the demo notebook).Also does
This is a minimum-viable product
Example before/after