mtvec vectored mode #755
Merged
mtvec vectored mode #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotro888
reviewed
Nov 19, 2024
test/asm/interrupt_vectored.asm
Outdated
Comment on lines
100
to
113
| # load state | ||
| mv x1, x12 | ||
| mv x2, x13 | ||
| mv x3, x14 | ||
| # fibonacci step | ||
| beq x3, x15, skip | ||
| add x3, x2, x1 | ||
| mv x1, x2 | ||
| mv x2, x3 | ||
| # store state | ||
| mv x12, x1 | ||
| mv x13, x2 | ||
| mv x14, x3 | ||
| j skip |
There was a problem hiding this comment.
This a common section int0_handler, it can just jump inside there to avoid code duplication.
There was a problem hiding this comment.
Two handlers use different registers, that stores global state checked in the test, only 4 middle lines are the same. I shortened it by removing the load state and store state sections
piotro888
reviewed
Nov 25, 2024
piotro888
approved these changes
Nov 26, 2024
tilk
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement vectored interrupt mode in mtvec (issue #745)