Add adapter module for bus #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilk
reviewed
Jan 15, 2024
tilk
reviewed
Jan 15, 2024
piotro888
reviewed
Jan 21, 2024
tilk
approved these changes
Jan 24, 2024
lekcyjna123
approved these changes
Jan 27, 2024
tilk
requested changes
Jan 27, 2024
Comment on lines
16
to
32
| class BusParametersInterface(Protocol): | ||
| """ | ||
| Bus Parameters Interface for common buses | ||
|
|
||
| Parameters | ||
| ---------- | ||
| data_width : int | ||
| An integer that describe the width of data for parametrized bus. | ||
| addr_width : int | ||
| An integer that describe the width of address for parametrized bus. | ||
| granularity : int | ||
| An integer that describe the granularity of accesses for parametrized bus. | ||
| """ | ||
|
|
||
| data_width: int | ||
| addr_width: int | ||
| granularity: int |
There was a problem hiding this comment.
Is the use of a Protocol necessary here? Shouldn't this just become a dataclass?
There was a problem hiding this comment.
If it would be dataclass then all specific buses implementations will have to use it for holding parameters. Presumably some bus can have different parameters than other buses and then that dataclass will have to be extended and in some cases would have redundant fields. Please correct me if I am missing something.
With Protocol we specify parameters that are important from Common Bus Master side point of view.
There was a problem hiding this comment.
Let's keep it the way it is for now.
tilk
approved these changes
Jan 29, 2024
|
There are conflicts to be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #531