Autumn cleaning: layouts #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekcyjna123
approved these changes
Nov 4, 2023
kindlermikolaj
approved these changes
Nov 13, 2023
test/structs_common/test_rs.py
Outdated
| yield Settle() | ||
| self.assertEqual((yield self.m.rs.data[1].rs_data.rp_s2), 0) | ||
| self.assertEqual((yield self.m.rs.data[1].rs_data.s2_val), value_sp2) | ||
| self.assertEqual((yield self.m.rs.data[1].rec_ready), 1) | ||
|
|
||
| # Insert new insturction to entries 0 and 1, check if update of multiple tags works | ||
| tag = 4 | ||
| # Insert new insturction to entries 0 and 1, check if update of multiple registers works |
tilk
added a commit
to kuznia-rdzeni/transactron
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
layouts.pyfile to increase readability and consistency. It introduces fields classes, which store field definitions (together with their names). The fields are then used in the layout definition classes. I was able to factor out most of the field definitions.Edit: factored out some local fields, as we discussed during the meeting. I also made some additional changes to improve consistency and make the names state more clearly what they represent.