Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allows NavTabs to overflow #1632

Merged
merged 2 commits into from
Oct 20, 2023
Merged

chore: allows NavTabs to overflow #1632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a81501d
chore: allows NavTabs to overflow
Oct 17, 2023
01c5ed5
fix: response layout issue with .app-content-container
Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/app/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ const isWizard = computed(() => route.meta.isWizard === true)
.app-content-container {
padding-top: var(--AppHeaderHeight, initial);
display: var(--AppDisplay);
grid-template-columns: var(--AppSidebarWidth) 1fr;
// Note: `minmax(0, 1fr)` is used because `1fr` implies `minmax(auto, 1fr)` which will allow grid items to grow beyond their container's size.
grid-template-columns: var(--AppSidebarWidth) minmax(0, 1fr);
}

.app-main-content {
Expand Down
17 changes: 17 additions & 0 deletions src/app/common/NavTabs.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,20 @@ const currentTabHash = computed(() => {
margin-bottom: var(--AppGap);
}
</style>

<style lang="scss">
.nav-tabs {
overflow-x: auto;
width: 100%;
}

.nav-tabs .tab-item {
white-space: nowrap;
}

// TODO: Remove this once https://github.com/Kong/kongponents/pull/1774 is available.
// Prevents KTabs from trigger a vertical overflow of its container.
.nav-tabs .tab-item::after {
content: none !important;
}
</style>