Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: allows NavTabs to overflow #1632

Merged
merged 2 commits into from
Oct 20, 2023
Merged

chore: allows NavTabs to overflow #1632

merged 2 commits into from
Oct 20, 2023

Conversation

kleinfreund
Copy link
Contributor

Allows NavTabs to overflow using a scroll container.

Prevents NavTabs items from wrapping.

Signed-off-by: Philipp Rudloff [email protected]

chore: allows NavTabs to overflow
a81501d 
Allows NavTabs to overflow using a scroll container.

Prevents NavTabs items from wrapping.

Signed-off-by: Philipp Rudloff <[email protected]>
@kleinfreund kleinfreund self-assigned this Oct 17, 2023
@kleinfreund kleinfreund requested a review from a team as a code owner October 17, 2023 14:14
@kleinfreund kleinfreund requested review from johncowen and removed request for a team October 17, 2023 14:14
@netlify
Copy link

netlify bot commented Oct 17, 2023 •
edited
Loading

✅ Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit 01c5ed5
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/65312494f1d1250008bef267
😎 Deploy Preview https://deploy-preview-1632--kuma-gui.netlify.app/gui
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Oct 17, 2023
Merged
Closed
@johncowen
Copy link
Contributor

Where's the best place in the App to see this working? I'm trying to find a place where the tabs would scroll so I can see it working.

@kleinfreund
Copy link
Contributor Author

Where's the best place in the App to see this working? I'm trying to find a place where the tabs would scroll so I can see it working.

This coming into effect is currently not possible because of a small layout bug that I’m addressing in 38f5723.

This fix addresses how the main content area overflows: it currently triggers a horizontal scroll bar on the entire content area which is problematic.

With both this PR and that change, you can see this easily on any view that shows the meshes tabs while the viewport is small enough.

@johncowen
Copy link
Contributor

Should we move that commit over here? Feels like it belongs in this PR? Rather than the summary view one.

fix: response layout issue with .app-content-container
01c5ed5 
Allows .app-content-container items to shrink in smaller viewports.

Signed-off-by: Philipp Rudloff <[email protected]>
@kleinfreund
Copy link
Contributor Author

Should we move that commit over here?

I did so now.

johncowen
johncowen approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 nice!

LGTM!

@kleinfreund kleinfreund merged commit 5785cec into kumahq:master Oct 20, 2023
15 checks passed
@kleinfreund kleinfreund deleted the chore/allows-nav-tabs-to-overflow branch October 20, 2023 08:34
@kleinfreund kleinfreund removed their assignment Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncowen johncowen johncowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kleinfreund @johncowen