Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sigs,generate: improve validation, update sig-list generation #350

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

sigs,generate: improve validation, update sig-list generation #350

wants to merge 7 commits into from

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Nov 6, 2024 •
edited
Loading

What this PR does / why we need it:

This PR improves the validation of sigs.yaml - it checks entries with

  • existing directories (sig/wg)
  • existing labels (using project-infra labels.yaml)
  • whether github accounts are actually org members (using project-infra orgs.yaml)

If --dry-run flag is false it will overwrite the orgs.yaml with the result, where each entry that failed to check will have been removed.

Also it adds to make target generate the run of the validation with --dry-run=false which will lead to a modified sigs.yaml which in turn will update the sig-list.md with corrected entries, which will then fail the check whether all changes have been committed.

This effectively will automate the validation whether all changes are correct and have been applied to generated markdown.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #321

Special notes for your reviewer:

@kubevirt-bot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 6, 2024
@dhiller dhiller mentioned this pull request Nov 7, 2024
Merged
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2024
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Nov 12, 2024

/test ?

@kubevirt-bot
Copy link

@dhiller: The following commands are available to trigger required jobs:

  • /test pull-community-make-generate
  • /test pull-community-validate-sigs-yaml

Use /test all to run the following jobs that were automatically triggered:

  • pull-community-make-generate

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dhiller
Copy link
Contributor Author

dhiller commented Nov 12, 2024

/rehearse ?

@dhiller
Copy link
Contributor Author

dhiller commented Nov 12, 2024

/test pull-community-make-generate

@dhiller
Copy link
Contributor Author

dhiller commented Nov 12, 2024

@dhiller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-community-make-generate a519c22 link true /test pull-community-make-generate

Error makes sense, since we need to modify the presubmit to add the project-infra directory, so that the binary can access it.

@dhiller
Copy link
Contributor Author

dhiller commented Nov 13, 2024

/hold

since this PR requires an update of pull-community-make-generate - it needs the project-infra checkout to access labels.yaml and orgs.yaml as described in PR description.

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2024
@dhiller dhiller marked this pull request as ready for review November 13, 2024 10:15
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2024
@dhiller dhiller mentioned this pull request Nov 14, 2024
Merged
@dhiller
Copy link
Contributor Author

dhiller commented Nov 14, 2024 •
edited
Loading

pull-community-make-generate

Will be fixed by kubevirt/project-infra#3761

@dhiller
Copy link
Contributor Author

dhiller commented Nov 15, 2024

/test pull-community-make-generate

@dhiller
Copy link
Contributor Author

dhiller commented Nov 15, 2024

/unhold

should be ready to go in now.

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2024
@dhiller dhiller mentioned this pull request Nov 15, 2024
Merged
@dhiller
Copy link
Contributor Author

dhiller commented Nov 15, 2024

/hold

to wait for kubevirt/project-infra#3762 to go in

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Nov 21, 2024

kubevirt/project-infra#3762 is required to go in before this can work - however we should make this land soon, since it ensures that no more errors wrt labels and github handles sneak in.

FYI @vladikr @aburdenthehand

@aburdenthehand
Copy link
Member

/lgtm
On premise but I can't review the code

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Nov 21, 2024

As a followup we should remove the pull-community-validate-sigs-yaml job, since the call is added here anyway

@dhiller
Copy link
Contributor Author

dhiller commented Nov 21, 2024

/test pull-community-make-generate

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from aburdenthehand. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhiller
Copy link
Contributor Author

dhiller commented Nov 21, 2024

/test pull-community-make-generate

1 similar comment
@dhiller
Copy link
Contributor Author

dhiller commented Nov 22, 2024

/test pull-community-make-generate

@dhiller
sigs,validator: update validator code
8da9f39 
Update validator code to take into account new sigs.yaml fields.
Add validation for chairs, leads, labels and directories.

Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
update sig-list md template - missing values
dc7e18f 
Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
generate: add sig validator call
a1636cc 
Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
sigs.yaml: remove non existing dirs and OWNERS
e2710a2 
Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
wg,arch: update labels to future correct ones
98a5bf3 
Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
sigs.yaml,chairs: add kubevirt community chair
45a7ed9 
Add aburdenthehand as community chair.

Note: this is only stating the obvious

Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
sigs.yaml: run make generate to fix formatting
5ab99d9 
This also updates sig-list.md with latest changes.

Signed-off-by: Daniel Hiller <[email protected]>
@kubevirt-bot
Copy link

kubevirt-bot commented Nov 22, 2024 •
edited
Loading

@dhiller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-community-validate-sigs-yaml 5ab99d9 link true /test pull-community-validate-sigs-yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dhiller dhiller mentioned this pull request Nov 22, 2024
Merged
8 tasks
@dhiller
Copy link
Contributor Author

dhiller commented Nov 22, 2024

As a followup we should remove the pull-community-validate-sigs-yaml job, since the call is added here anyway

kubevirt/project-infra#3779 will remove the presubmit

@dhiller
Copy link
Contributor Author

dhiller commented Nov 22, 2024

/uncc @cwilkers
/cc @vladikr

Adding Vladik for attention around sigs.yaml validation (hope you find the time :) )

@kubevirt-bot kubevirt-bot requested review from vladikr and removed request for cwilkers November 22, 2024 08:58
@aburdenthehand
Copy link
Member

/lgtm
Just re-adding the label from before :)

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aburdenthehand aburdenthehand Awaiting requested review from aburdenthehand

@jean-edouard jean-edouard Awaiting requested review from jean-edouard

@vladikr vladikr Awaiting requested review from vladikr

Assignees

@aburdenthehand aburdenthehand

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sig-list.md: create postsubmit prow job that updates after changes to sigs.yaml
3 participants
@dhiller @kubevirt-bot @aburdenthehand