Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community,sigs.yaml: remove sigs.yaml validation #3779

Merged

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Nov 22, 2024

What this PR does / why we need it:

This will be obsolete as of the latest changes in the validation update PR kubevirt/community#350, therefore we are deleting this presubmit.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @brianmcarey @aburdenthehand

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


This will be obsolete as of the latest changes in the validation update
PR, therefore we are deleting this presubmit.

Signed-off-by: Daniel Hiller <[email protected]>
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2024
@kubevirt-bot kubevirt-bot merged commit 3b18c69 into kubevirt:main Nov 22, 2024
4 of 5 checks passed
@kubevirt-bot
Copy link
Contributor

@dhiller: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key community-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/community/community-presubmits.yaml

In response to this:

What this PR does / why we need it:

This will be obsolete as of the latest changes in the validation update PR kubevirt/community#350, therefore we are deleting this presubmit.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @brianmcarey @aburdenthehand

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants