-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community,generate: add project-infra extra_ref #3761
community,generate: add project-infra extra_ref #3761
Conversation
Since we want to use the configuration files inside the project-infra to validate community documents as `sigs.yaml` we add an extra ref so that they are availabe when running the presubmit. Signed-off-by: Daniel Hiller <[email protected]>
/rehearse |
Rehearsal jobs created for this PR:
You can trigger rehearsal for all jobs by commenting either For a specific PR you can comment For a list of jobs that you can rehearse you can comment |
@dhiller: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks @dhiller - I think the rehearsal won't work as project-infra is already included in the rehearsal yaml.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeah, I remembered after I triggered the rehearsal... /override rehearsal-pull-community-make-generate |
@dhiller: Overrode contexts on behalf of dhiller: rehearsal-pull-community-make-generate In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dhiller: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Since we want to use the configuration files inside the project-infra to validate community documents as
sigs.yaml
we add an extra ref so that they are availabe when running the presubmit.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/cc @brianmcarey @aburdenthehand
See kubevirt/community#350 (comment)