Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community,generate: add project-infra extra_ref #3761

Merged

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Nov 14, 2024

What this PR does / why we need it:

Since we want to use the configuration files inside the project-infra to validate community documents as sigs.yaml we add an extra ref so that they are availabe when running the presubmit.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @brianmcarey @aburdenthehand

See kubevirt/community#350 (comment)

Since we want to use the configuration files inside the project-infra to
validate community documents as `sigs.yaml` we add an extra ref so that
they are availabe when running the presubmit.

Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
Copy link
Contributor Author

dhiller commented Nov 14, 2024

/rehearse

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-community-make-generate

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@kubevirt-bot
Copy link
Contributor

@dhiller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
rehearsal-pull-community-make-generate 29b7efd link unknown /test pull-community-make-generate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks @dhiller - I think the rehearsal won't work as project-infra is already included in the rehearsal yaml.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Nov 15, 2024

/approve

Thanks @dhiller - I think the rehearsal won't work as project-infra is already included in the rehearsal yaml.

Yeah, I remembered after I triggered the rehearsal...

/override rehearsal-pull-community-make-generate

@kubevirt-bot
Copy link
Contributor

@dhiller: Overrode contexts on behalf of dhiller: rehearsal-pull-community-make-generate

In response to this:

/approve

Thanks @dhiller - I think the rehearsal won't work as project-infra is already included in the rehearsal yaml.

Yeah, I remembered after I triggered the rehearsal...

/override rehearsal-pull-community-make-generate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot merged commit 21d1c16 into kubevirt:main Nov 15, 2024
6 checks passed
@kubevirt-bot
Copy link
Contributor

@dhiller: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key community-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/community/community-presubmits.yaml

In response to this:

What this PR does / why we need it:

Since we want to use the configuration files inside the project-infra to validate community documents as sigs.yaml we add an extra ref so that they are availabe when running the presubmit.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @brianmcarey @aburdenthehand

See kubevirt/community#350 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants