Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure probe-timeout is shorter than livenessProbe #2931

Closed
wants to merge 1 commit into from
Closed

Ensure probe-timeout is shorter than livenessProbe #2931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions manifests/vanilla/vsphere-csi-driver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,7 @@ spec:
args:
- "--v=4"
- "--csi-address=/csi/csi.sock"
- "--probe-timeout=4s"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacen57 do you think this needs to updated in the documentation here - https://github.com/kubernetes-csi/livenessprobe?tab=readme-ov-file#command-line-options

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this for other liveness-probe container in the same file?
https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/ed4a34ac281bc907825f73466eab5a38a4374c6b/manifests/vanilla/vsphere-csi-driver.yaml#L532C17-L533

volumeMounts:
- name: plugin-dir
mountPath: /csi
Expand Down