-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure probe-timeout is shorter than livenessProbe #2931
Conversation
Ensure probe-timeout of the liveness-probe container is shorter than livenessProbe of the vsphere-csi-node container
The committers listed above are authorized under a signed CLA. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jacen57 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @jacen57! |
Hi @jacen57. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@@ -676,6 +676,7 @@ spec: | |||
args: | |||
- "--v=4" | |||
- "--csi-address=/csi/csi.sock" | |||
- "--probe-timeout=4s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacen57 do you think this needs to updated in the documentation here - https://github.com/kubernetes-csi/livenessprobe?tab=readme-ov-file#command-line-options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update this for other liveness-probe container in the same file?
https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/ed4a34ac281bc907825f73466eab5a38a4374c6b/manifests/vanilla/vsphere-csi-driver.yaml#L532C17-L533
What this PR does / why we need it:
Ensure probe-timeout of the liveness-probe container is shorter than livenessProbe of the vsphere-csi-node container
Without this, if the socket probe takes too long, another livenessProbe check is started while the previous is not finished. Liveness probe requests pile up until the container liveness-probe failed in CrashLoopBackoff
Testing done:
Yes
Special notes for your reviewer:
Release note: