-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md Fixing issue # https://github.com/kubernetes-sigs/secrets-store-sync-controller/issues/86 #87
base: main
Are you sure you want to change the base?
Conversation
Fixins issue # kubernetes-sigs#86 As per https://github.com/kubernetes-sigs/secrets-store-sync-controller/blob/main/Makefile#L53C1-L54 https://github.com/kubernetes-sigs/secrets-store-sync-controller/blob/main/Makefile#L172 https://github.com/kubernetes-sigs/secrets-store-sync-controller/blob/main/Makefile#L106-L110 The README.md file provides instructions for deploying the controller (https://github.com/kubernetes-sigs/secrets-store-sync-controller?tab=readme-ov-file#deploy-the-controller). However, there are discrepancies between the instructions and the actual outcomes of the commands. Specifically, when executing the command: VERSION=e2e make docker-build The resulting Docker image is named controller:e2e instead of secrets-store-sync-controller:e2e as stated in the documentation. This inconsistency between the documentation and the actual behavior may lead to confusion for users attempting to deploy the controller.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jayeshmahajan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @jayeshmahajan! |
Hi @jayeshmahajan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
/assign @nilekhc |
@nilekhc - Let me know if you need anything from me here. |
Fixing issue # #86
As per
https://github.com/kubernetes-sigs/secrets-store-sync-controller/blob/main/Makefile#L172
https://github.com/kubernetes-sigs/secrets-store-sync-controller/blob/main/Makefile#L106-L110
https://github.com/kubernetes-sigs/secrets-store-sync-controller/blob/main/Makefile#L53C1-L54
The README.md file provides instructions for deploying the controller (https://github.com/kubernetes-sigs/secrets-store-sync-controller?tab=readme-ov-file#deploy-the-controller). However, there are discrepancies between the instructions and the actual outcomes of the commands.
Specifically, when executing the command: VERSION=e2e make docker-build The resulting Docker image is named controller:e2e instead of secrets-store-sync-controller:e2e as stated in the documentation. This inconsistency between the documentation and the actual behavior may lead to confusion for users attempting to deploy the controller.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: