-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency between README instructions and Makefile output #86
Comments
/good-first-issue |
@omerap12: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixins issue # kubernetes-sigs#86 As per https://github.com/kubernetes-sigs/secrets-store-sync-controller/blob/main/Makefile#L53C1-L54 https://github.com/kubernetes-sigs/secrets-store-sync-controller/blob/main/Makefile#L172 https://github.com/kubernetes-sigs/secrets-store-sync-controller/blob/main/Makefile#L106-L110 The README.md file provides instructions for deploying the controller (https://github.com/kubernetes-sigs/secrets-store-sync-controller?tab=readme-ov-file#deploy-the-controller). However, there are discrepancies between the instructions and the actual outcomes of the commands. Specifically, when executing the command: VERSION=e2e make docker-build The resulting Docker image is named controller:e2e instead of secrets-store-sync-controller:e2e as stated in the documentation. This inconsistency between the documentation and the actual behavior may lead to confusion for users attempting to deploy the controller.
PR #87 |
/assign |
The README.md file provides instructions for deploying the controller (https://github.com/kubernetes-sigs/secrets-store-sync-controller?tab=readme-ov-file#deploy-the-controller). However, there are discrepancies between the instructions and the actual outcomes of the commands.
Specifically, when executing the command:
VERSION=e2e make docker-build
The resulting Docker image is named controller:e2e instead of secrets-store-sync-controller:e2e as stated in the documentation.
This inconsistency between the documentation and the actual behavior may lead to confusion for users attempting to deploy the controller.
The text was updated successfully, but these errors were encountered: