Update workflow and docs for releasing Spark operator #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenYi015
changed the title
|
/assign @yuchaoran2011 @vara-bonthu @andreyvelich |
ChenYi015
force-pushed
the
workflow/release
branch
from
f3321e8
to
ae2e175
Compare
Signed-off-by: Yi Chen <[email protected]>
ChenYi015
force-pushed
the
workflow/release
branch
2 times, most recently
from
0aba1a6
to
14152b0
Compare
|
@yuchaoran2011 PTAL. |
Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
ChenYi015
force-pushed
the
workflow/release
branch
from
14152b0
to
2810ddf
Compare
Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
|
/hold cancel |
|
@andreyvelich Do you think it is ok? After this PR and #2072 are merged, we can make a |
Yeah, but we need to cherry-pick all of the required PRs into |
vara-bonthu
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
@ChenYi015
Thanks for the PR and it's going to streamline the release process.
Once this PR is merged and all the approvers are satisfied, we can proceed to create the v2.0.0-rc.0 release. We need to ensure we cherry pick changes merged to main until the new release branch is merged.
/approve
Signed-off-by: Yi Chen <[email protected]>
ChenYi015
force-pushed
the
workflow/release
branch
from
6034df8
to
34f2891
Compare
|
@yuchaoran2011 Could you also review this PR? I have tested this workflow and it works fine. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vara-bonthu, yuchaoran2011 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
ChenYi015
added a commit
to ChenYi015/spark-operator
that referenced
this pull request
Aug 2, 2024
* Update .helmignore Signed-off-by: Yi Chen <[email protected]> * Add release docs Signed-off-by: Yi Chen <[email protected]> * Update release workflow Signed-off-by: Yi Chen <[email protected]> * Update integration test workflow Signed-off-by: Yi Chen <[email protected]> * Add workflow for pushing tag when VERSION file changes Signed-off-by: Yi Chen <[email protected]> * Update Signed-off-by: Yi Chen <[email protected]> * Remove the leading 'v' from chart version Signed-off-by: Yi Chen <[email protected]> * Update docker image tags Signed-off-by: Yi Chen <[email protected]> --------- Signed-off-by: Yi Chen <[email protected]> (cherry picked from commit a3ec8f1)
8 tasks
YanivKunda
pushed a commit
to YanivKunda/spark-operator
that referenced
this pull request
Aug 5, 2024
* Update .helmignore Signed-off-by: Yi Chen <[email protected]> * Add release docs Signed-off-by: Yi Chen <[email protected]> * Update release workflow Signed-off-by: Yi Chen <[email protected]> * Update integration test workflow Signed-off-by: Yi Chen <[email protected]> * Add workflow for pushing tag when VERSION file changes Signed-off-by: Yi Chen <[email protected]> * Update Signed-off-by: Yi Chen <[email protected]> * Remove the leading 'v' from chart version Signed-off-by: Yi Chen <[email protected]> * Update docker image tags Signed-off-by: Yi Chen <[email protected]> --------- Signed-off-by: Yi Chen <[email protected]>
google-oss-prow bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
* Update workflow and docs for releasing Spark operator (#2089) * Update .helmignore Signed-off-by: Yi Chen <[email protected]> * Add release docs Signed-off-by: Yi Chen <[email protected]> * Update release workflow Signed-off-by: Yi Chen <[email protected]> * Update integration test workflow Signed-off-by: Yi Chen <[email protected]> * Add workflow for pushing tag when VERSION file changes Signed-off-by: Yi Chen <[email protected]> * Update Signed-off-by: Yi Chen <[email protected]> * Remove the leading 'v' from chart version Signed-off-by: Yi Chen <[email protected]> * Update docker image tags Signed-off-by: Yi Chen <[email protected]> --------- Signed-off-by: Yi Chen <[email protected]> (cherry picked from commit a3ec8f1) * Fix broken integration test CI (#2109) Signed-off-by: Yi Chen <[email protected]> (cherry picked from commit 6ff204a) * Fix CI: environment variable BRANCH is missed (#2111) Signed-off-by: Yi Chen <[email protected]> (cherry picked from commit e2693f1)
Merged
sigmarkarl
pushed a commit
to spotinst/spark-on-k8s-operator
that referenced
this pull request
Aug 7, 2024
* Update .helmignore Signed-off-by: Yi Chen <[email protected]> * Add release docs Signed-off-by: Yi Chen <[email protected]> * Update release workflow Signed-off-by: Yi Chen <[email protected]> * Update integration test workflow Signed-off-by: Yi Chen <[email protected]> * Add workflow for pushing tag when VERSION file changes Signed-off-by: Yi Chen <[email protected]> * Update Signed-off-by: Yi Chen <[email protected]> * Remove the leading 'v' from chart version Signed-off-by: Yi Chen <[email protected]> * Update docker image tags Signed-off-by: Yi Chen <[email protected]> --------- Signed-off-by: Yi Chen <[email protected]>
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
* Update workflow and docs for releasing Spark operator (kubeflow#2089) * Update .helmignore Signed-off-by: Yi Chen <[email protected]> * Add release docs Signed-off-by: Yi Chen <[email protected]> * Update release workflow Signed-off-by: Yi Chen <[email protected]> * Update integration test workflow Signed-off-by: Yi Chen <[email protected]> * Add workflow for pushing tag when VERSION file changes Signed-off-by: Yi Chen <[email protected]> * Update Signed-off-by: Yi Chen <[email protected]> * Remove the leading 'v' from chart version Signed-off-by: Yi Chen <[email protected]> * Update docker image tags Signed-off-by: Yi Chen <[email protected]> --------- Signed-off-by: Yi Chen <[email protected]> (cherry picked from commit a3ec8f1) * Fix broken integration test CI (kubeflow#2109) Signed-off-by: Yi Chen <[email protected]> (cherry picked from commit 6ff204a) * Fix CI: environment variable BRANCH is missed (kubeflow#2111) Signed-off-by: Yi Chen <[email protected]> (cherry picked from commit e2693f1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Update release workflow:
mainbranch andrelease-*branch.v*.*.*tag is pushed, a workflow will be triggered to build and push docker images to Docker Hub.v*.*.*tag is pushed, a workflow will be triggered to create a draft release.Change Category
Indicate the type of change by marking the applicable boxes:
Rationale
Checklist
Before submitting your PR, please review the following:
Additional Notes