Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick #2089 #2109 #2111 #2110

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

ChenYi015
Copy link
Contributor

@ChenYi015 ChenYi015 commented Aug 2, 2024

Purpose of this PR

The GitHub action workflow is not triggered by release-* branch, we should cherrypick related workflow files into the release branch.

Proposed changes:

Cherry pick the following commits:

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

* Update .helmignore

Signed-off-by: Yi Chen <[email protected]>

* Add release docs

Signed-off-by: Yi Chen <[email protected]>

* Update release workflow

Signed-off-by: Yi Chen <[email protected]>

* Update integration test workflow

Signed-off-by: Yi Chen <[email protected]>

* Add workflow for pushing tag when VERSION file changes

Signed-off-by: Yi Chen <[email protected]>

* Update

Signed-off-by: Yi Chen <[email protected]>

* Remove the leading 'v' from chart version

Signed-off-by: Yi Chen <[email protected]>

* Update docker image tags

Signed-off-by: Yi Chen <[email protected]>

---------

Signed-off-by: Yi Chen <[email protected]>
(cherry picked from commit a3ec8f1)
Signed-off-by: Yi Chen <[email protected]>
(cherry picked from commit 6ff204a)
@ChenYi015
Copy link
Contributor Author

/hold

@ChenYi015 ChenYi015 changed the title Cherry pick #2089 #2109 Cherry pick #2089 #2109 #2111 Aug 2, 2024
@ChenYi015
Copy link
Contributor Author

/hold cancel
/assign @yuchaoran2011 @vara-bonthu

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 6, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 53c6aed into kubeflow:release-2.0 Aug 6, 2024
7 checks passed
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
* Update workflow and docs for releasing Spark operator (kubeflow#2089)

* Update .helmignore

Signed-off-by: Yi Chen <[email protected]>

* Add release docs

Signed-off-by: Yi Chen <[email protected]>

* Update release workflow

Signed-off-by: Yi Chen <[email protected]>

* Update integration test workflow

Signed-off-by: Yi Chen <[email protected]>

* Add workflow for pushing tag when VERSION file changes

Signed-off-by: Yi Chen <[email protected]>

* Update

Signed-off-by: Yi Chen <[email protected]>

* Remove the leading 'v' from chart version

Signed-off-by: Yi Chen <[email protected]>

* Update docker image tags

Signed-off-by: Yi Chen <[email protected]>

---------

Signed-off-by: Yi Chen <[email protected]>
(cherry picked from commit a3ec8f1)

* Fix broken integration test CI (kubeflow#2109)

Signed-off-by: Yi Chen <[email protected]>
(cherry picked from commit 6ff204a)

* Fix CI: environment variable BRANCH is missed (kubeflow#2111)

Signed-off-by: Yi Chen <[email protected]>
(cherry picked from commit e2693f1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants