Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VSLAM-demo example #109

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Add VSLAM-demo example #109

merged 3 commits into from
Oct 31, 2022

Conversation

jike5
Copy link
Contributor

@jike5 jike5 commented Sep 29, 2022

What type of PR is this?

kubeedge/examples#120

#92

What this PR does / why we need it:

[OSPP] Code for Implementation of an VSLAM Algorithm on KubeEdge

In order to develop a practical system, we follow the architectural design from edgeslam, still, with numerous modifications for our scenario. Relying on the cloud-edge management and cloud-edge communication function provided by kubeedge and edgemesh, a complete cloud-edge collaborative SLAM system is implemented. In this system, the edge side is responsible for sensor data collection, feature extraction and data sending, while the cloud side is in charge of loop closing and global mapping.

@kubeedge-bot kubeedge-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 29, 2022
sig-robotics/examples/VSLAM-demo/README.md Outdated Show resolved Hide resolved

```bash
docker ps -a | grep orbslam
docker exec -it [containerID] bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just naming the container with --name so you don't need to look up the id.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, you are right

sig-robotics/examples/VSLAM-demo/README.md Outdated Show resolved Hide resolved
| fr2_desk | 0.05 | 0.12 |
| fr3_office | 0.02 | 0.04 |

<img src="images/结果对比图.png" alt="结果对比图" style="zoom:50%;" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to name the file in English

&& rm -rf ./build \
&& ./build.sh

RUN bash -i -c "echo 'ROS_PACKAGE_PATH=/opt/ros/melodic/share:/workspace/edgeslam/Examples/ROS'>>~/.bashrc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENV ROS_PACKAGE_PATH "/opt/ros/melodic/share:/workspace/edgeslam/Examples/ROS"

@JoeyHwong-gk
Copy link
Contributor

JoeyHwong-gk commented Oct 27, 2022

Thanks for your contribution!

  1. As the proposal is repeated with the previous PR Add VSLAM proposal #92 , just keep one of them.

  2. Rebase commits when your work is done.

  3. Push your container image to dockerhub and submit more source code please.

  4. Please add the license to the top of the execution scripts


> We use [TUM Datasets](https://vision.in.tum.de/data/datasets/rgbd-dataset/download) and its format in our development and test process.

4. Check your work node's name and modify the deployment.yaml file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With all nodes running on the cluster, we create the deployment by using the yaml file below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directly replace the sentence 4. Check your work... with this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have modified it, thanks a lot

@JoeyHwong-gk
Copy link
Contributor

/lgtm

@kubeedge-bot
Copy link
Collaborator

@JoeyHwong-gk: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: jike5 <[email protected]>

Signed-off-by: jike5 <[email protected]>

Signed-off-by: jike5 <[email protected]>

Signed-off-by: jike5 <[email protected]>

Signed-off-by: jike5 <[email protected]>
@fisherxu
Copy link
Member

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2022
@fisherxu fisherxu added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2022
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot merged commit 5314153 into kubeedge:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants