Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable auto request reviewers feature #240

Merged
merged 2 commits into from
May 23, 2022
Merged

Disable auto request reviewers feature #240

merged 2 commits into from
May 23, 2022

Commits on May 23, 2022

  1. fix: remove auto request reviewers 

    The auto request reviewers feature never really worked well. The problem
is that it tries to copy the current open review requests, but when a PR
is merged, most of those reviews have already been completed. When
completed, they are no longer in the review request list.

The feature became problematic for users when using a bot user (PAT)
that does not have admin rights to the repository. Those rights are
necessary to request reviewers in some repos.

Multiple solutions were possible, but as this feature doesn't behave
as wanted, and might even be unexpected to some users (breaking the
principle of least astonishment), I believe it should simply be removed.
We can always re-introduce it with a configuration option at a later
time.
    @korthout
    korthout committed May 23, 2022
    Configuration menu
    Copy the full SHA
    04324b4 View commit details
    Browse the repository at this point in the history

  2. dist: build a new version

    @korthout
    korthout committed May 23, 2022
    Configuration menu
    Copy the full SHA
    93a5c52 View commit details
    Browse the repository at this point in the history