Disable auto request reviewers feature #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auto request reviewers feature never really worked well. The problem is that it tries to copy the current open review requests, but when a PR is merged, most of those reviews have already been completed. When completed, they are no longer in the review request list. The feature became problematic for users when using a bot user (PAT) that does not have admin rights to the repository. Those rights are necessary to request reviewers in some repos. Multiple solutions were possible, but as this feature doesn't behave as wanted, and might even be unexpected to some users (breaking the principle of least astonishment), I believe it should simply be removed. We can always re-introduce it with a configuration option at a later time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto-request reviewers feature never really worked well. The problem is that it tries to copy the current open review requests, but when a PR is merged, most of those reviews have already been completed. When completed, they are no longer on the review request list. So most of the time, the backport PR is created without a request for reviewers.
The feature became problematic for users when using a bot user (PAT) that does not have admin rights to the repository. Those rights are necessary to request reviewers in some repos. See #239.
Multiple solutions were possible, but as this feature doesn't behave as wanted, and might even be unexpected to some users (breaking the principle of least astonishment), I believe it should simply be removed. We can always re-introduce it with a configuration option at a later time.
reverts #4
fixes #239