Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 19 Upgrade #802

Merged
merged 1 commit into from
Jul 15, 2024
Merged

React 19 Upgrade #802

merged 1 commit into from
Jul 15, 2024

Conversation

jackpope
Copy link

@jackpope jackpope commented May 7, 2024

As described in #799, React 19 has some breaking changes that will require updates from third-party rendering libraries. I needed to get a new build of react-konva with React 19 working and I wanted to publish the updates here to share the required changes. Hopefully for a new release to go with React 19!

Changes in this PR

  • Upgrade its-fine
  • Add new reconciler methods to host config
  • Update signature of commitUpdate
  • Use React.act instead of timeouts in tests

@lavrton
Copy link
Member

lavrton commented May 10, 2024

Thank you so much for your Pull Request. I will review it soon.
Usually, I prefer to publish a new version AFTER a new react version is published.

@rjungbeck
Copy link

I tried to use the patch in my react-konva based app (that also uses react-konva-utils).

I came across the same issues in react-konva-utils (at least I got similar errors messages). So we will probably need the same type of workaround there,

@PupoSDC
Copy link

PupoSDC commented May 21, 2024

I'm struggling getting this working on my own. I tried downloading the package, building it, and using that to patch package the current version... but I keep hitting this error:

TypeError: Cannot read properties of undefined (reading 'ReactCurrentOwner')

@jackpope would you be so kind as to publish a version of this as a package?

@lavrton
Copy link
Member

lavrton commented May 21, 2024 via email

@lavrton
Copy link
Member

lavrton commented May 21, 2024

I released 19.0.0-0. Try it.

@lavrton
Copy link
Member

lavrton commented May 21, 2024

@jackpope I had some issues with npm run build. Do you have time to take a look? I temporarily removed the usage of NoEventPriority.

@PupoSDC
Copy link

PupoSDC commented May 22, 2024

First testing looks like this is working. Thank you very much for this intermediate release. I will be testing it a bit more thoroughly in the coming days!

@Micnubinub
Copy link

Anyone else getting this in the newer versions?

TypeError: reactDom.findDOMNode is not a function

@lavrton lavrton merged commit ba195da into konvajs:master Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants