Log uncaught errors for React 19 #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks. Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on an implementation of React Server Components and I was happy to see this PR merged migrating to the new React 19
react-reconcilerAPI. This mostly fixed my issues but I noticed errors were getting swallowed (with aonUncaughtError is undefined). This is because there's a newReactFiberReconciler.createContainersignature with more error handling options. This PR fixes that for me by passingconsole.errorinto those options.I'm not sure what your preferred solve for this would be but I'd be happy to take guidance and update this PR with tests to implement it.
Thank you for maintaining such a nice library!