Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mhoemmen @amklinv-nnl @fnrizzi
Changes:
Kokkos
builds alongNative
ones with Kokkos tests executed;Release
andDebug
modes (also MDSpan, Kokkos and Kokkos-Kernels);ubuntu-latest
offers GCC 10.3.0 and new CMake (imageamklinv/stdblas:latest
can't be used anymore because it has CMake 3.13.4 while Kokkos requires 3.16+)Kokkos testing
Kokkos builds make Kokkos execution policy the default one with
LINALG_ENABLE_KOKKOS_DEFAULT=ON
, which leads to native tests executing Kokkos implementations and eventually yielding different results than in Native builds.We could consider extending this one-way cross-testing to Kokkos tests executing the serial implementation - if they were called with serial execution policy (they explicitly use
KokkosKernelsSTD::kokkos_exec<>()
, so they only test Kokkos implementations now).