Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kokkos tests to CI #213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mzuzek
Copy link

@mzuzek mzuzek commented May 21, 2022

@mhoemmen @amklinv-nnl @fnrizzi

Changes:

  • Add Kokkos builds along Native ones with Kokkos tests executed;
  • Build and test in Release and Debug modes (also MDSpan, Kokkos and Kokkos-Kernels);
  • Refactoring:
    • reduced/simplified jobs and removed artifact exchange to save time job setup (native workflow execution time dropped from 4m to 1m, and Kokkos workflow takes about 2.5m);
    • container no longer required as bare ubuntu-latest offers GCC 10.3.0 and new CMake (image amklinv/stdblas:latest can't be used anymore because it has CMake 3.13.4 while Kokkos requires 3.16+)

Kokkos testing

Kokkos builds make Kokkos execution policy the default one with LINALG_ENABLE_KOKKOS_DEFAULT=ON, which leads to native tests executing Kokkos implementations and eventually yielding different results than in Native builds.

We could consider extending this one-way cross-testing to Kokkos tests executing the serial implementation - if they were called with serial execution policy (they explicitly use KokkosKernelsSTD::kokkos_exec<>(), so they only test Kokkos implementations now).

@mzuzek mzuzek force-pushed the 171-ci-kokkos-tests branch 30 times, most recently from 78777fa to 2cf1bad Compare May 24, 2022 07:59
@mzuzek mzuzek force-pushed the 171-ci-kokkos-tests branch 11 times, most recently from 7bfadec to 46ab1fb Compare May 24, 2022 21:22
@mzuzek mzuzek self-assigned this May 25, 2022
@mzuzek mzuzek force-pushed the 171-ci-kokkos-tests branch 7 times, most recently from 4cf25c1 to 84c3973 Compare May 27, 2022 09:27
@mzuzek mzuzek changed the title [wip] add kokkos tests to CI add kokkos tests to CI May 27, 2022
@mzuzek mzuzek changed the title add kokkos tests to CI Add kokkos tests to CI May 27, 2022
@mzuzek
Copy link
Author

mzuzek commented May 27, 2022

@mhoemmen @fnrizzi

Let me open this PR for review: the script is pretty much drafted and test failures are not caused by it, so they may addressed on separate, dedicated issues and PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant