blas2 and blas3: update kokkos include header and cmakelist for tests #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoemmen
approved these changes
May 20, 2022
mzuzek
force-pushed
the
blas2_kk_include_and_test_cmakelist
branch
from
4df56ae
to
ccaab88
Compare
mzuzek
changed the title
mzuzek
force-pushed
the
blas2_kk_include_and_test_cmakelist
branch
from
ccaab88
to
5ae995a
Compare
mzuzek
force-pushed
the
blas2_kk_include_and_test_cmakelist
branch
from
5ae995a
to
a95dd22
Compare
|
It looks fine -- just waiting on the automated tests. |
|
Thanks @mhoemmen, this PR is needed to solve tests Would you instead like the failing tests to be temporarily disabled and merge #213 first to activate auto-testing before merging other PRs like this ? |
|
@MikolajZuzek Thanks for asking! I've merged this PR. I would generally prefer tests to be fixed before merging PRs like #213. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.