-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark results processing and deployment #1
Open
cz4rs
wants to merge
3
commits into
kokkos:main
Choose a base branch
from
cz4rs:process-benchmark-results
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
name: Process benchmark results | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
workflow_dispatch: | ||
|
||
jobs: | ||
run-benchmark-monitor: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout processing script | ||
uses: actions/checkout@v3 | ||
with: | ||
repository: cz4rs/benchmark_monitor | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
with: | ||
path: benchmark-results | ||
|
||
- name: Process available benchmark results | ||
run: |- | ||
pip3 install -r requirements.txt | ||
python3 benchmark_monitor.py -s 50 -d ./benchmark-results -o output | ||
|
||
- name: Generate nojekyll file | ||
working-directory: output | ||
run: touch .nojekyll | ||
|
||
- name: Deploy | ||
if: ${{ github.ref == 'refs/heads/main' }} | ||
uses: JamesIves/github-pages-deploy-action@v4 | ||
with: | ||
folder: output | ||
branch: deploy-benchmarks | ||
clean: true | ||
single-commit: true | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,18 @@ | ||
# kokkos-benchmark-results | ||
|
||
Repository for storing performance benchmark results. | ||
|
||
## Generate performance graphs locally | ||
```sh | ||
# get benchmark results and processing script | ||
git clone [email protected]:kokkos/benchmark_monitor.git | ||
git clone [email protected]:kokkos/kokkos-benchmark-results.git | ||
cd benchmark_monitor | ||
# create and activate virtual environment | ||
python3 -m venv env | ||
source env/bin/activate | ||
# continue inside a virtual environment | ||
pip install -r requirements.txt | ||
python benchmark_monitor.py -d ../benchmark-results -o output | ||
cz4rs marked this conversation as resolved.
Show resolved
Hide resolved
|
||
``` | ||
This will generate `index.html` and the rest of files in `output` diectory. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original script: https://github.com/bensanmorris/benchmark_monitor
I have modified / customized it for our use case here: https://github.com/cz4rs/benchmark_monitor
I propose that we fork the original thing and I will deliver my changes with a pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree on forking this inside kokkos is the best option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking back at this, I think this whole step should be removed and
benchmark_monitor.py
script (plus the templates andrequirements.txt
) should be added to a subdirectory in this repo.