-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark results processing and deployment #1
base: main
Are you sure you want to change the base?
Conversation
c0cabbf
to
1ef4975
Compare
- name: Checkout processing script | ||
uses: actions/checkout@v3 | ||
with: | ||
repository: cz4rs/benchmark_monitor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repository: cz4rs/benchmark_monitor | |
repository: kokkos/benchmark_monitor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original script: https://github.com/bensanmorris/benchmark_monitor
I have modified / customized it for our use case here: https://github.com/cz4rs/benchmark_monitor
I propose that we fork the original thing and I will deliver my changes with a pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree on forking this inside kokkos is the best option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking back at this, I think this whole step should be removed and benchmark_monitor.py
script (plus the templates and requirements.txt
) should be added to a subdirectory in this repo.
95d36dc
to
8e42a88
Compare
f7a5d2e
to
886bbe5
Compare
18ccb52
to
ded96e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my minor comment
9808512
to
82ad433
Compare
82ad433
to
788b20d
Compare
788b20d
to
713c54b
Compare
713c54b
to
20181d8
Compare
Did ever get back to this? |
I haven't tested it since the last push (Apr 2023), but functionally this was ready to go at the time. The only change I would make is to simply add Main drawback is that the results from GitHub runners are no that great (not an isolated environment for reliable performance measurement). IIRC there were talks about having something similar run on Jenkins (with proper isolation and CUDA enabled). |
fixes kokkos/kokkos#5464
Process benchmark results and deploy generated pages.
Deployment targets
deploy-benchmarks
branch of this repository and should make the webpage appear at https://kokkos.github.io/kokkos-benchmark-results/.