Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new search component - implement Combobox approach #506

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

feat: new search component - implement Combobox approach #506

wants to merge 24 commits into from

Commits on Oct 16, 2024

  1. feat(search): start impl

    @MengLinMaker
    MengLinMaker committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c4fe83f View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2024

  1. chore: import Combobox as Search for base implementation

    @MengLinMaker
    MengLinMaker committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    cb52142 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. feat: wrap Combobox to disable defaultFilter internally

    @MengLinMaker
    MengLinMaker committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f977150 View commit details
    Browse the repository at this point in the history

  2. chore: remove extraneous type

    @MengLinMaker
    MengLinMaker committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ea322dd View commit details
    Browse the repository at this point in the history

  3. feat: add debouncer for option suggestions

    @MengLinMaker
    MengLinMaker committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    79f63f0 View commit details
    Browse the repository at this point in the history

  4. chore: remove irrelevant components - ErrorMessage, ItemIndicator, Tr… 

    …igger
    @MengLinMaker
    MengLinMaker committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ea00403 View commit details
    Browse the repository at this point in the history

  5. feat: display NoResult component when no options are shown

    @MengLinMaker
    MengLinMaker committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    52bcf59 View commit details
    Browse the repository at this point in the history

  6. feat: add Search.Indicator to visually display loading

    @MengLinMaker
    MengLinMaker committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    75d761c View commit details
    Browse the repository at this point in the history

  7. docs: add Search doc without examples yet

    @MengLinMaker
    MengLinMaker committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    6e92a57 View commit details
    Browse the repository at this point in the history

  8. fix: remove TypeScript issues

    @MengLinMaker
    MengLinMaker committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f8fd683 View commit details
    Browse the repository at this point in the history

  9. docs: fix incorrect anatomy

    @MengLinMaker
    MengLinMaker committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    c0b1db6 View commit details
    Browse the repository at this point in the history

  10. docs: add emoji search example

    @MengLinMaker
    MengLinMaker committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b7e2f69 View commit details
    Browse the repository at this point in the history

  11. chore: correct combobox to search

    @MengLinMaker
    MengLinMaker committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    6c734af View commit details
    Browse the repository at this point in the history

  12. docs: remove Search.ItemDescription doc since this component does not… 

    … exist
    @MengLinMaker
    MengLinMaker committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    4c88a06 View commit details
    Browse the repository at this point in the history

  13. fix: onChange should stop onInputChange trigger - onInputChange trigg… 

    …ers before onChange
    @MengLinMaker
    MengLinMaker committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    806f8e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. feat: (combobox) add noResetInputOnBlur feature to prevent input re… 

    …sets on combobox blur
    @MengLinMaker
    MengLinMaker committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2594383 View commit details
    Browse the repository at this point in the history

  2. feat: auto detect NoResults component prescence when empty options is… 

    … given
    @MengLinMaker
    MengLinMaker committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    9c503a5 View commit details
    Browse the repository at this point in the history

  3. feat: better Search interaction defaults

    @MengLinMaker
    MengLinMaker committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e3646e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. fix: (combobox) allowsEmptyCollection should display dropdown even … 

    …when `options` is empty
    @MengLinMaker
    MengLinMaker committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    898973d View commit details
    Browse the repository at this point in the history

  2. Revert "feat: auto detect NoResults component prescence when empty op… 

    …tions is given"

This reverts commit 9c503a5.
    @MengLinMaker
    MengLinMaker committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    96736ed View commit details
    Browse the repository at this point in the history

  3. docs: separate basic and debounce example

    @MengLinMaker
    MengLinMaker committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e31a1ea View commit details
    Browse the repository at this point in the history

  4. test(search): working tests from combobox

    @MengLinMaker
    MengLinMaker committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    c5c7f71 View commit details
    Browse the repository at this point in the history

  5. test(search): add DebouncerTimeout test

    @MengLinMaker
    MengLinMaker committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3559681 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. docs(search): add cmdk style example

    @MengLinMaker
    MengLinMaker committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    aaafbfd View commit details
    Browse the repository at this point in the history