-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new search component - implement Combobox approach #506
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for kobalte ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SolutionCancel timeouts when onChange is triggered. (May introduce flickering momentarily to loading icon?) ProblemExample search: Screen.Recording.2024-10-29.at.8.38.00.am.mp4Note: debouncer is triggered as emoji is selected (indicated by spinner), this should not happen. |
…ers before onChange
Typing fast then stopping somehow does not display suggestion options: Screen.Recording.2024-10-29.at.9.07.16.am.mp4Issue seems to occur when:
|
133e245
to
5141e63
Compare
5141e63
to
e3646e8
Compare
The dropdown bug - solutionFound the cause of the bug:
The possible fix:
|
…when `options` is empty
013b2b7
to
898973d
Compare
…tions is given" This reverts commit 9c503a5.
@jer3m01 I think this component is ready for review |
406b47f
to
aaafbfd
Compare
Fixed some dark mode styling issues: |
Draft
Search
component implementation using Combobox underneath. #504This solution should be more maintainable than #501
Component
Combobox
components asSearch
SearchRoot
to implementComboBoxBase
disabling defaultFilter as this is handled externally - eg: databaseTest
Doc
Bugs:
options
-> typing -> non-emptyoptions
-> results in no dropdown unless dropdown is already open (Nani? ¯_(ツ)_/¯)noResetInputOnBlur
option to ComboboxNote: I'm using
minisearch
npm package to perform text search