[traffic-gen-in-vm] Add trex config files #149

RamLavi · 2023-07-19T10:58:05Z

This PR adds config files to the trex package, that will be consumed in the checkup's traffic-gen configmap.
These files are going to be consumed by the trex VMI in later PRs.

RamLavi · 2023-07-19T11:16:55Z

$  TEST_NAMESPACE=dpdk-checkup-ns-1 NETWORK_ATTACHMENT_DEFINITION_NAME=dpdk-sriovnetwork-ns-1 RUNTIME_CLASS_NAME=performance-profile-1 make TEST_IMAGE=quay.io/ramlavi/kubevirt-dpdk-checkup:latest TRAFFIC_GEN_IMAGE_URL=quay.io/kiagnose/kubevirt-dpdk-checkup-traffic-gen:traffic-gen-in-vm VM_CONTAINER_DISK_IMAGE_URL=quay.io/kiagnose/kubevirt-dpdk-checkup-vm:traffic-gen-in-vm test/e2e
docker run --rm \
           --volume /home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup:/home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup:Z \
           --volume /home/ralavi/.kube:/root/.kube:Z,ro \
           --workdir /home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup \
           -e KUBECONFIG=/root/.kube/kubeconfig \
           -e TEST_IMAGE=quay.io/ramlavi/kubevirt-dpdk-checkup:latest \
           -e TEST_NAMESPACE=dpdk-checkup-ns-1 \
           -e NETWORK_ATTACHMENT_DEFINITION_NAME=dpdk-sriovnetwork-ns-1 \
           -e TRAFFIC_GEN_IMAGE_URL=quay.io/kiagnose/kubevirt-dpdk-checkup-traffic-gen:traffic-gen-in-vm \
           -e VM_CONTAINER_DISK_IMAGE_URL=quay.io/kiagnose/kubevirt-dpdk-checkup-vm:traffic-gen-in-vm \
           docker.io/library/golang:1.20.6 go test ./tests/... -test.v -test.timeout=1h -ginkgo.v -ginkgo.timeout=1h
=== RUN   TestKubevirtDpdkCheckup
Running Suite: KubevirtDpdkCheckup Suite - /home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup/tests
==============================================================================================================
Random Seed: 1689765054

Will run 1 of 1 specs
------------------------------
[BeforeSuite] 
/home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup/tests/test_suite_test.go:60
[BeforeSuite] PASSED [0.002 seconds]
------------------------------
Execute the checkup Job should complete successfully
/home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup/tests/checkup_test.go:79
• [143.181 seconds]
------------------------------

Ran 1 of 1 Specs in 143.184 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestKubevirtDpdkCheckup (143.18s)
PASS
ok  	github.com/kiagnose/kubevirt-dpdk-checkup/tests	143.206s

orelmisan

Thank you @RamLavi.

Have you tried to run TRex with the files generated by the PR?

pkg/internal/checkup/trex/configfiles.go

pkg/internal/checkup/trex/configfiles_test.go

pkg/internal/checkup/trex/configfiles.go

orelmisan · 2023-07-19T11:41:01Z

pkg/internal/checkup/trex/configfiles.go

+	}
+}
+
+func (t Configs) GetTrexCfgFile() string {


nit:
Please consider other verbs like Generate or Create.

Same for the other functions.

pkg/internal/checkup/configmap/configmap_test.go

RamLavi · 2023-07-19T12:13:36Z

Change: Review fixes

RamLavi · 2023-07-19T12:19:01Z

$  TEST_NAMESPACE=dpdk-checkup-ns-1 NETWORK_ATTACHMENT_DEFINITION_NAME=dpdk-sriovnetwork-ns-1 make TEST_IMAGE=quay.io/ramlavi/kubevirt-dpdk-checkup:latest TRAFFIC_GEN_IMAGE_URL=quay.io/kiagnose/kubevirt-dpdk-checkup-traffic-gen:traffic-gen-in-vm VM_CONTAINER_DISK_IMAGE_URL=quay.io/kiagnose/kubevirt-dpdk-checkup-vm:traffic-gen-in-vm test/e2e
docker run --rm \
           --volume /home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup:/home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup:Z \
           --volume /home/ralavi/.kube:/root/.kube:Z,ro \
           --workdir /home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup \
           -e KUBECONFIG=/root/.kube/kubeconfig \
           -e TEST_IMAGE=quay.io/ramlavi/kubevirt-dpdk-checkup:latest \
           -e TEST_NAMESPACE=dpdk-checkup-ns-1 \
           -e NETWORK_ATTACHMENT_DEFINITION_NAME=dpdk-sriovnetwork-ns-1 \
           -e TRAFFIC_GEN_IMAGE_URL=quay.io/kiagnose/kubevirt-dpdk-checkup-traffic-gen:traffic-gen-in-vm \
           -e VM_CONTAINER_DISK_IMAGE_URL=quay.io/kiagnose/kubevirt-dpdk-checkup-vm:traffic-gen-in-vm \
           docker.io/library/golang:1.20.6 go test ./tests/... -test.v -test.timeout=1h -ginkgo.v -ginkgo.timeout=1h
=== RUN   TestKubevirtDpdkCheckup
Running Suite: KubevirtDpdkCheckup Suite - /home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup/tests
==============================================================================================================
Random Seed: 1689768882

Will run 1 of 1 specs
------------------------------
[BeforeSuite] 
/home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup/tests/test_suite_test.go:60
[BeforeSuite] PASSED [0.002 seconds]
------------------------------
Execute the checkup Job should complete successfully
/home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup/tests/checkup_test.go:79
• [243.674 seconds]
------------------------------

Ran 1 of 1 Specs in 243.677 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestKubevirtDpdkCheckup (243.68s)
PASS
ok  	github.com/kiagnose/kubevirt-dpdk-checkup/tests	243.697s

Currently the trex package is only used on the executor package. In preparation of expanding its use to the higher level checkup package, moving trex package to be under it. Signed-off-by: Ram Lavi <[email protected]>

The trex application needs some configuration files in order to run [1]. These configuration files iare represented by template files that need to be configured with the checkup's config parameter input. Introducing a new file that contains the config file templates and returns the outputted files for future use in later commits. [1] https://github.com/kiagnose/kubevirt-dpdk-checkup/tree/630d0497b2ba17a91245b93e37719ce50be4ddaa/traffic-gen/templates Signed-off-by: Ram Lavi <[email protected]>

Signed-off-by: Ram Lavi <[email protected]>

RamLavi force-pushed the add_config_files branch from f07a8f3 to cff1681 Compare July 19, 2023 11:05

RamLavi changed the title ~~Add config files~~ [traffic-gen-in-vm] Add config files Jul 19, 2023

RamLavi force-pushed the add_config_files branch from cff1681 to b977b2e Compare July 19, 2023 11:09

RamLavi requested a review from orelmisan July 19, 2023 11:31

orelmisan reviewed Jul 19, 2023

View reviewed changes

RamLavi force-pushed the add_config_files branch from b977b2e to 1539028 Compare July 19, 2023 12:13

RamLavi changed the title ~~[traffic-gen-in-vm] Add config files~~ [traffic-gen-in-vm] Add trex config files Jul 19, 2023

trex: Move package to be under checkup package

de33445

Currently the trex package is only used on the executor package. In preparation of expanding its use to the higher level checkup package, moving trex package to be under it. Signed-off-by: Ram Lavi <[email protected]>

RamLavi force-pushed the add_config_files branch from 1539028 to d7753fd Compare July 19, 2023 12:41

RamLavi added 2 commits July 19, 2023 15:46

checkup, configmap: Add traffic-gen configmap Data

b1a2f40

Signed-off-by: Ram Lavi <[email protected]>

RamLavi force-pushed the add_config_files branch from d7753fd to b1a2f40 Compare July 19, 2023 12:47

orelmisan approved these changes Jul 19, 2023

View reviewed changes

RamLavi merged commit 221e65f into kiagnose:traffic-gen-in-vm Jul 19, 2023
4 checks passed

This was referenced Jul 19, 2023

[traffic-gen-in-vm] Place TRex config file and scripts #150

Merged

Convert traffic generator pod to a VM #163

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[traffic-gen-in-vm] Add trex config files #149

[traffic-gen-in-vm] Add trex config files #149

RamLavi commented Jul 19, 2023 •

edited

Loading

RamLavi commented Jul 19, 2023

orelmisan left a comment

orelmisan Jul 19, 2023

RamLavi Jul 19, 2023

RamLavi commented Jul 19, 2023

RamLavi commented Jul 19, 2023

[traffic-gen-in-vm] Add trex config files #149

[traffic-gen-in-vm] Add trex config files #149

Conversation

RamLavi commented Jul 19, 2023 • edited Loading

RamLavi commented Jul 19, 2023

orelmisan left a comment

Choose a reason for hiding this comment

orelmisan Jul 19, 2023

Choose a reason for hiding this comment

RamLavi Jul 19, 2023

Choose a reason for hiding this comment

RamLavi commented Jul 19, 2023

RamLavi commented Jul 19, 2023

RamLavi commented Jul 19, 2023 •

edited

Loading