-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[traffic-gen-in-vm] Add trex config files #149
Conversation
f07a8f3
to
cff1681
Compare
cff1681
to
b977b2e
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @RamLavi.
Have you tried to run TRex with the files generated by the PR?
} | ||
} | ||
|
||
func (t Configs) GetTrexCfgFile() string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
Please consider other verbs like Generate
or Create
.
Same for the other functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
b977b2e
to
1539028
Compare
Change: Review fixes |
|
Currently the trex package is only used on the executor package. In preparation of expanding its use to the higher level checkup package, moving trex package to be under it. Signed-off-by: Ram Lavi <[email protected]>
1539028
to
d7753fd
Compare
The trex application needs some configuration files in order to run [1]. These configuration files iare represented by template files that need to be configured with the checkup's config parameter input. Introducing a new file that contains the config file templates and returns the outputted files for future use in later commits. [1] https://github.com/kiagnose/kubevirt-dpdk-checkup/tree/630d0497b2ba17a91245b93e37719ce50be4ddaa/traffic-gen/templates Signed-off-by: Ram Lavi <[email protected]>
Signed-off-by: Ram Lavi <[email protected]>
d7753fd
to
b1a2f40
Compare
This PR adds config files to the trex package, that will be consumed in the checkup's traffic-gen configmap.
These files are going to be consumed by the trex VMI in later PRs.