[traffic-gen-in-vm] Place TRex config file and scripts #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When mounting the disk containing the ConfigMap, the files are read only. Copy the TRex configuration file to `/etc` using cloud-init. Signed-off-by: Orel Misan <[email protected]>
When mounting the disk containing the ConfigMap, the files are read only. Create a directory to hold the Python scripts that will be used by TRex. Signed-off-by: Orel Misan <[email protected]>
Copy the Python scripts from the disk containing the ConfigMap data to `/opt/tests`. Signed-off-by: Orel Misan <[email protected]>
|
Tested against an OpenShift Virtualization 4.14 cluster. |
RamLavi
reviewed
Jul 20, 2023
| @@ -143,10 +143,12 @@ func CloudInit(username, password string, bootCommands []string) string { | |||
|
|
|||
| func trafficGenBootCommands(configDiskSerial string) []string { | |||
| const configMountDirectory = "/mnt/app-config" | |||
| const testScriptsDirectory = "/opt/tests" | |||
There was a problem hiding this comment.
this const is going to be used also in the executor (see main branch reference here)
Do we want to make it a const on the trex package perhaps?
There was a problem hiding this comment.
This is a good idea.
The problem is, that currently there is no file with a proper name in the trex package to hold this const,
and I find creating a whole file just for this little const problematic.
I suggest to move it in the PR that will introduce the trex client logic.
WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR #149, the traffic-gen ConfigMap contains the TRex configuration file and several Python scripts.
When mounting the disk containing the ConfigMap, the files are read only.
/etcin the traffic-gen guest./opt/tests.AFAIU, there is no need to make the Python scripts executable, because they are not executed as standalone scripts,
and do not have a Shebang [1].
[1] https://en.wikipedia.org/wiki/Shebang_(Unix)