Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean old tests when recalculating durations #373

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Clean old tests when recalculating durations #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,11 @@ jobs:
env:
HYPOTHESIS_PROFILE: pr
run: >-
poetry run pytest -n auto --store-durations
poetry run pytest -n auto --store-durations --clean-durations
--doctest-modules --ignore=docs
--ignore=snakebids/project_template --benchmark-disable
- name: remove spuriously include "Dancefile.inject"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor point and can be ignored. Is there any reason for using git clean here rather than including the Dancefile.inject to the .gitignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just because the intent here is that nothing should be added. I don't know what the dancefile is or whence it comes, so putting in an ignore file is maybe weird?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fairpoint. I guess I was coming from the what if there are other untracked files that should be committed angle.

run: git clean -df
- name: Check if there are changes
id: changes
run: |
Expand All @@ -58,7 +60,7 @@ jobs:
branch: maint/update-test-timings
title: Merge updated test timings
labels: maintenance
body: |
body: >
The number of tests has changed since the last generated test-timings
file. This PR contains an automatically regenerated file.

Expand Down
Loading