Clean old tests when recalculating durations #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
akhanf,
Bradley-Karat,
kaitj,
mcespedes99 and
myousif9
kaitj
approved these changes
Feb 14, 2024
| --doctest-modules --ignore=docs | ||
| --ignore=snakebids/project_template --benchmark-disable | ||
| - name: remove spuriously include "Dancefile.inject" |
There was a problem hiding this comment.
Minor point and can be ignored. Is there any reason for using git clean here rather than including the Dancefile.inject to the .gitignore?
There was a problem hiding this comment.
Just because the intent here is that nothing should be added. I don't know what the dancefile is or whence it comes, so putting in an ignore file is maybe weird?
There was a problem hiding this comment.
Fairpoint. I guess I was coming from the what if there are other untracked files that should be committed angle.
Also attempts to remove the Dancefile.inject being added for some reason, possibly by the `build-docker-container` step
pvandyken
force-pushed
the
fix/nightly-tests
branch
from
c8d1e47 to
2b2ba51
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 39 39
Lines 1727 1727
=======================================
Hits 1582 1582
Misses 145 145 ☔ View full report in Codecov by Sentry. |
pvandyken
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also attempts to remove the
Dancefile.injectbeing added for some reason, possibly by thebuild-docker-containerstep