-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] [Discussion] Custom actions (extension/plugins) #1739
Conversation
💥 No ChangesetLatest commit: a8ee429 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
This is awesome mate! We need to unify the ideas from here with the comments from: #1665 I'm going to see if I can get the team together to decide how this might all work. |
we can also make use of refined naming I suggested at https://github.com/keystonejs/keystone-5/pull/1665#issuecomment-532194427 |
Let me get some feedback from everyone this week and then I'll get together with you and we can spec out and build a complete solution for Admin UI hooks. |
The custom actions stuff in #2101 should definitely be considered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On hold until we can spec out custom actions completely
Admin UI hooks have shipped (although we need to add the appropriate hook points) With this we will be able to deliver custom actions. |
ref: #1452 #310
Tried to work my way to add some extensibility, see this gif and explanation
Intention
intention is to enable devs write custom actions which can extend Admin UI with custom Buttons for List and List multi item select management.
working:
possibility
immediate possibility is to
add list item actions similar to allow duplicate item from list and on detail page #1724 Duplicate items from drop down ( this can also be refactored as list item action rather than in build feature)
add Item Action which is on the Item detail/Edit page.
I will work on these two after seeing positive feedback for first two actions working.
Beyond
later this can also extend to import plugins installed dynamically, I was not able to figure out (yet) the webpack stuff with field-view-loader to load from disk without bundling with webpack.
additionally we can also enable composing with other ui elements like