-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI tests and update to newer ACTS #13
Conversation
Can you add pre-commit and license while you are at it? |
@paulgessinger Are you OK with the Apache 2 License? |
Build test is waiting for key4hep/key4hep-spack#522 as Acts is unfortunately built without the dd4hep plugin in key4hep atm..
|
The other PR is merged but it seems like it's still failing to find the the plugin? |
We only expect the nightlies to pass and they do now. It will take until the next release for the other one... |
currently waiting for the opendatadetector to become available in the nightlies, it should be there tomorrow. Then we can use it directly in the ci without building it ourselves every time |
@Zehvogel I see, where is this built then? I'm wondering if keeping this in sync is really worth it since building it does not take a long time normally. |
@paulgessinger Is your question where the ODD is built? We added it to the key4hep-stack. At the moment we build the last tagged version, but we could also add it properly to the key4hep nightlies and have the latest main all the time... |
BEGINRELEASENOTES
ENDRELEASENOTES