Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GeoSvc to new convertDD4hepDetector interface #14

Closed
wants to merge 1 commit into from
Closed

Update GeoSvc to new convertDD4hepDetector interface #14

wants to merge 1 commit into from

Conversation

Zehvogel
Copy link
Collaborator

@Zehvogel Zehvogel commented Aug 28, 2023 •
edited
Loading

BEGINRELEASENOTES

  • Update GeoSvc to new (ACTS v24+) convertDD4hepDetector interface

ENDRELEASENOTES

needed once we bump the spack commit in key4hep-spack and do a new from scratch build.

I basically copied the changes from acts-project/acts#1911

@Zehvogel Zehvogel marked this pull request as ready for review September 19, 2023 09:01
@Zehvogel
Copy link
Collaborator Author

Changes moved into #13 as the stack was already updated

@Zehvogel Zehvogel closed this Sep 20, 2023
@Zehvogel Zehvogel deleted the logger branch September 20, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zehvogel @paulgessinger