This repository has been archived by the owner on May 22, 2023. It is now read-only.
Add TBTC monitoring confirmations #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function `waitForChainConfirmation` has been moved to a separate file and made public. This is because it can be reused in some other places.
Implemented deposit state confirmations upon monitoring stop event and action execution for the retrieve pubkey monitoring.
Implemented deposit state confirmations upon monitoring stop event and action execution for remaining monitoring instances.
pdyraga
reviewed
Nov 6, 2020
Merged
# Conflicts: # pkg/extensions/tbtc/tbtc.go
Keep closed and terminated events should be confirmed similarly as regular monitoring stop events to handle chain reorgs properly.
pdyraga
reviewed
Nov 12, 2020
Comment on lines
+30
to
+36
| func newTestTBTC(chain chain.TBTCHandle) *tbtc { | ||
| tbtc := newTBTC(chain) | ||
|
|
||
| tbtc.blockConfirmations = defaultLocalBlockConfirmations | ||
|
|
||
| return tbtc | ||
| } |
There was a problem hiding this comment.
I would go with just:
return &tbtc{
chain: chain,
blockConfirmations: defaultBlockConfirmations,
}
and got rid of newTBTC function that is used only here and in Initalize. See that we are getting nothing with newTBTC and we need to set the field to something else right after it's called.
There was a problem hiding this comment.
This PR #600 will give more sense for the newTBTC function. Also, the tbtc struct will probably grow over time.
There was a problem hiding this comment.
Cool, I'll leave this discussion open for now but let's don't care about it for this PR and revisit once we merge #600.
pdyraga
reviewed
Nov 12, 2020
pdyraga
reviewed
Nov 12, 2020
pdyraga
approved these changes
Nov 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #574
Depends on: #591
Depends on: keep-network/keep-common#56
Implemented chain confirmations upon monitoring stop events and after executing monitoring actions. This should prevent problems that may occur due to chain reorganizations.