Introduced separate package for chain-generic functions #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaitForBlockConfirmations works with any chain implementation so it should not be placed in /pkg/chain/ethereum/ethutil where Ethereum-specific utils live. From now on, the code using this util that works with chain abstractions can import pkg/chain/chainutil instead of having to import Ethereum implementation utilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WaitForBlockConfirmationsworks with any chain implementation so it should not be placed in/pkg/chain/ethereum/ethutilwhere Ethereum-specific utils live.From now on, the code using this util that works with chain abstractions can import
pkg/chain/chainutilinstead of having to import Ethereum implementation utilities.See keep-network/keep-ecdsa#592 (comment) for reference.