This repository has been archived by the owner on May 22, 2023. It is now read-only.
Prevent TBTC monitoring duplication #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented a monitoring lock mechanism which should prevent triggering duplicated monitoring instances. Those redundant instances can be started as response to duplicated events which are sometimes delivered by third-party Ethereum nodes.
Shadowfiend
reviewed
Nov 3, 2020
Merged
Heads up: even if the operator is not using Infura or Alchemy, and they are running their own Ethereum client, duplicate events are still happening for small chain re-orgs. |
pdyraga
reviewed
Nov 6, 2020
# Conflicts: # pkg/extensions/tbtc/tbtc.go
pdyraga
approved these changes
Nov 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #574
Depends on: #590
Implemented a monitoring lock mechanism that should prevent triggering duplicated monitoring instances. Those redundant instances can be started as a response to duplicated events that are sometimes delivered by third-party Ethereum nodes.