Introduce custom Ethereum client interface #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced custom `EthereumClient` interface which wraps several `go-ethereum` interfaces and use it as backend in the client wrappers. The main motivation is to improve wrappers usability. For example, logging and rate limiting clients can now be used by the block counter and mining waiter tools.
pdyraga
reviewed
Nov 6, 2020
pdyraga
approved these changes
Nov 10, 2020
|
To add some more color, this change was discussed here when we realized neither
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: keep-network/keep-ecdsa#574
Introduced custom
EthereumClientinterface which wraps severalgo-ethereuminterfaces and use it as backend in the client wrappers. The main motivation is to improve wrappers usability. For example, logging and rate-limiting clients can now be used by the block counter and mining waiter tools.