This repository has been archived by the owner on May 22, 2023. It is now read-only.
Improve Ethereum client wrappers adoption #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the way Ethereum client is used in the Ethereum chain implementation. Specifically, got rid of the bare client usages. Instead of that, the wrapped client which provides logging and rate limiting capabilities is used everywhere.
pdyraga
reviewed
Nov 6, 2020
|
@lukasz-zimnoch Can you please update this branch now having all 3 previous PRs merged? I'd love to have the fresh version of the code here before doing a final pass. |
pdyraga
approved these changes
Nov 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #574
Depends on: #585
Depends on: keep-network/keep-common#55
Changed the way Ethereum client is used in the Ethereum chain implementation. Specifically, got rid of the bare client
usages. Instead of that, the wrapped client which provides logging and rate-limiting capabilities is used everywhere.