forked from NeilMenne/cis194
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HW 2 init #5
Open
adkron
wants to merge
6
commits into
amos
Choose a base branch
from
amos2
base: amos
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
HW 2 init #5
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
60d0e92
Update Readme to show how to run a single test
adkron 36d6fab
Merge pull request #3 from kcelixir/adkron-patch-1
adkron a93524d
HW 2 init
adkron a04e954
Merge remote-tracking branch 'origin/master' into amos2
adkron d1fce6f
Updates with some review items from @glguy
adkron 5a7db0a
Removes reverse by using foldl instead of foldr
adkron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A note about a flaw in this exercise:
LogMessage
shouldn't have anUnknown
constructor. Error handling like this should be done in parallel to the type for valid log messages. At a minimum you might have:Either String LogMessage
or something. This causes problems later in the exercises when you have to ignoreUnknown
.