Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW 2 init #5

Open
wants to merge 6 commits into
base: amos
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ On a mac:
stack test
```

## Run a single test file

```
stack runghc -- -isrc -itest test/Cis194/Hw/SomeSpec.hs
```

## Using QuickCheck in ghci

:m +Test.QuickCheck
Expand Down
34 changes: 29 additions & 5 deletions src/Cis194/Hw/LogAnalysis.hs
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,46 @@ module Cis194.Hw.LogAnalysis where
import Cis194.Hw.Log
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note about a flaw in this exercise: LogMessage shouldn't have an Unknown constructor. Error handling like this should be done in parallel to the type for valid log messages. At a minimum you might have: Either String LogMessage or something. This causes problems later in the exercises when you have to ignore Unknown.


parseMessage :: String -> LogMessage
parseMessage s = Unknown s
parseMessage s =
case words s of
"E":i:t:ws -> buildMessage (Error (read i)) t ws
"I":t:ws -> buildMessage Info t ws
"W":t:ws -> buildMessage Warning t ws
_ -> Unknown s

buildMessage :: MessageType -> String -> [String] -> LogMessage
buildMessage m t ws = LogMessage m (read t) (unwords ws)

parse :: String -> [LogMessage]
parse _ = []
parse = map parseMessage . lines

insert :: LogMessage -> MessageTree -> MessageTree
insert Unknown{} t = t
insert l Leaf = Node Leaf l Leaf
insert n@(LogMessage _ nt _) (Node l m@(LogMessage _ mt _) r)
| nt < mt = Node (insert n l) m r
| nt > mt = Node l m (insert n r)
insert _ t = t

build :: [LogMessage] -> MessageTree
build _ = Leaf
build = foldl (flip insert) Leaf

inOrder :: MessageTree -> [LogMessage]
inOrder _ = []
inOrder t = go t []
where
go (Node l m r) = go l . (m:) . go r
go Leaf = id

-- whatWentWrong takes an unsorted list of LogMessages, and returns a list of the
-- messages corresponding to any errors with a severity of 50 or greater,
-- sorted by timestamp.
whatWentWrong :: [LogMessage] -> [String]
whatWentWrong _ = []
whatWentWrong = map getString . filter isSevere . inOrder . build

isSevere :: LogMessage -> Bool
isSevere (LogMessage (Error s) _ _) = s >= 50
isSevere _ = False

getString :: LogMessage -> String
getString (LogMessage _ _ s) = s
getString (Unknown s) = s