Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HW 2 init #5

Open
wants to merge 6 commits into
base: amos
Choose a base branch
from
Open

HW 2 init #5

wants to merge 6 commits into from

Commits on Nov 19, 2018

  1. Update Readme to show how to run a single test 

    When working through the code it is often nice to be able to run a single test.

Amos King @adkron <[email protected]>
    @adkron
    adkron authored Nov 19, 2018
    Configuration menu
    Copy the full SHA
    60d0e92 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2018

  1. Merge pull request #3 from kcelixir/adkron-patch-1 

    Update Readme to show how to run a single test
    @adkron
    adkron authored Nov 20, 2018
    Configuration menu
    Copy the full SHA
    36d6fab View commit details
    Browse the repository at this point in the history

  2. HW 2 init 

    I have an issue with `buildMessage` not being exhaustive because it
needs to match on an empty map. I really didn't like building all this
stuff in the case statement and that is why I pulled it out. I think I
need to start thinking of functions returning functions and build it up
as arguments get passed in.

Amos King @adkron <[email protected]>
    @adkron
    adkron committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    a93524d View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2018

  1. Merge remote-tracking branch 'origin/master' into amos2

    @adkron
    adkron committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    a04e954 View commit details
    Browse the repository at this point in the history

  2. Updates with some review items from @glguy 

    I really like the pattern that was used in `inOrder` that was brilliant. Thanks
for the help and the pointer on matching a type constructor.

Amos King @adkron <[email protected]>
    @adkron
    adkron committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    d1fce6f View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2018

  1. Removes reverse by using foldl instead of foldr 

    foldl and foldr expect arguments in different orders, but flip allows the
arguments to be flipped.

Amos King @adkron <[email protected]>
    @adkron
    adkron committed Nov 25, 2018
    Configuration menu
    Copy the full SHA
    5a7db0a View commit details
    Browse the repository at this point in the history