Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add :nomore_files to return stream #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add :nomore_files to return stream #4

wants to merge 4 commits into from

Commits on Jul 26, 2016

  1. Return a :nomore_files atom when there are no more files in the zip 

    Previously, {:new_file, name} is not returned after the last file, this makes it difficult for downstream to know that the last chunk has been received, so as to return a stream item indicating that all binary chunks of the file has been fully received/processes.
For example, if using after_fun in `ZipStream.unzip |> Stream.transform`, there would be no way to return, `{:ok, file_name}` indicating that the last file is complete.
    @heri16
    heri16 authored Jul 26, 2016
    Configuration menu
    Copy the full SHA
    f3ce14d View commit details
    Browse the repository at this point in the history

  2. Update README.md to reflect :nomore_files in stream

    @heri16
    heri16 authored Jul 26, 2016
    Configuration menu
    Copy the full SHA
    86d418a View commit details
    Browse the repository at this point in the history

  3. Bump minor version to indicate minor change in API 

    API is changes as `:nomore_files` atom is expected in the returned stream from `ZipStream.unzip/1`
    @heri16
    heri16 authored Jul 26, 2016
    Configuration menu
    Copy the full SHA
    32e8bc1 View commit details
    Browse the repository at this point in the history

  4. Update README.md

    @heri16
    heri16 authored Jul 26, 2016
    Configuration menu
    Copy the full SHA
    51e7d8c View commit details
    Browse the repository at this point in the history