Add :nomore_files to return stream

[heri16]

Currently, {:new_file, nil} is not returned after the last file, this makes it difficult for downstream to know that the last chunk has been received. This means that the downstream cannot return an item indicating that all binary chunks of the last file have been fully received/processes.

For example, if using after_fun in ZipStream.unzip |> Stream.transform, there would be no way to return, {:ok, file_name} indicating that the last file is complete.

[awetzel]

Yes good catch, useful because the :halt of the stream can happen before the end of the stream (for instance with an Enum.take). The drawback is that the new API is not backward compatible so I/and other user, have to modify projects using this lib (that's why the version bump in the PR is welcomed :) ). But I am not sure why the tests do not pass anymore, did you investigate ?

PS: thank you !

[heri16]

Ah... I missed the tests. Will work on them and get back.

On Friday, 29 July 2016, Arnaud Wetzel [email protected] wrote:

Yes good catch, useful because the :halt of the stream can happen before
the end of the stream (for instance with an Enum.take). The drawback is
that the new API is not backward compatible so I/and other user, have to
modify projects using this lib (that's why the version bump in the PR is
welcomed :) ). But I am not sure why the tests do not pass anymore, did you
investigate ?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgK_WJ0JocRLLQpOWGaldKiHdQw5S3Tks5qaOB6gaJpZM4JVM3e
.

[heri16]

Is there a style of API that you prefer? Is :nomore_files ok, or something else? @awetzel

[ananthakumaran]

The typical way is to just use Stream.concat(stream, [:__eof__])