Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Sudden Termination #73

Merged
merged 19 commits into from
Nov 27, 2012
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
04526f5
Don't bother trying to unload parsers on termination.
mikeabdullah Aug 13, 2012
5456741
Parser controller no longer does anything with notifications.
mikeabdullah Aug 13, 2012
69736f0
note an oddity of -dealloc
mikeabdullah Aug 13, 2012
a8dd295
Factor out -saveWindowStateToPreferences:
mikeabdullah Aug 13, 2012
0601ad0
Use window moving or resizing to trigger saving of state.
mikeabdullah Aug 13, 2012
080eec6
Save selected media type on-demand too.
mikeabdullah Aug 13, 2012
926bf31
No longer need to observe app terminating to save state.
mikeabdullah Aug 13, 2012
250b973
Spotted another occasion of needless mutability.
mikeabdullah Aug 13, 2012
60193a0
Save some state automatically.
mikeabdullah Aug 13, 2012
614f73b
Save selection state live too.
mikeabdullah Aug 13, 2012
93c5564
No longer care about observing termination.
mikeabdullah Aug 13, 2012
eb363dd
Spotted another occasion of needless mutability.
mikeabdullah Aug 13, 2012
8082e73
There is no point nilling out ivars at init time.
mikeabdullah Aug 13, 2012
7653ce0
Make .expandedNodeIdentifiers sane by declaring as NSArray, copy.
mikeabdullah Aug 13, 2012
c287e66
Rename as -_setExpandedNodeIdentifiersFromOutlineView for clarity.
mikeabdullah Aug 13, 2012
67b7638
Persist node expansion as it happens.
mikeabdullah Aug 13, 2012
b3fafaf
Redeclare .selectedNodeIdentifier to be copy, and persist the selection.
mikeabdullah Aug 13, 2012
cc1ec2c
No longer care about observing termination.
mikeabdullah Aug 13, 2012
25a080b
Grab prefs from correct sub dictionary.
mikeabdullah Aug 19, 2012
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
note an oddity of -dealloc
  • Loading branch information
mikeabdullah committed Aug 13, 2012

Verified

This commit was signed with the committer’s verified signature.
TimothyWillard Timothy Willard
commit 69736f062d121ac6d0ec3c7a6e4a2331db30c8a4
2 changes: 1 addition & 1 deletion IMBParserController.m
Original file line number Diff line number Diff line change
@@ -198,7 +198,7 @@ - (id) init

- (void) dealloc
{
[self reset];
[self reset]; // -reset calls through to the delegate. A proper client will have set the delegate to nil if this is being deallocated though
[super dealloc];
}