-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Sudden Termination #73
Conversation
* There's likely no useful teardown to be done here * Sudden termination means the notification may not be posted * None of our parsers is actually doing anything from it
It seems to me that there is a bug in commit eb363dd The new line should be:
Instead of:
The current code always returns nil and the expanded nodes states is not restored. |
@yoavhacohen thanks for spotting this; fixed in 25a080b |
Thanks for the quick fix. |
Do you have any evidence for this? The frameworks are pretty good at automatically disabling sudden termination on your behalf as appropriate. I admit I haven't looked at automatic termination yet though; would argue it's a different case. |
Compatibility with Sudden Termination
Various fixes to quiet warnings about nullability, clang analyis issues, potential memory leaks.
Prefs etc. are updated as they change, rather than waiting till the app quitting.
NSUserDefaults
is smart enough not to make that expensive.Addresses issue #71