Ci pnpm #509
Ci pnpm #509
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@mcanueste is attempting to deploy a commit to the kamp-us Team on Vercel. A member of the Team first needs to authorize it. |
| "@kampus/kampus": "*", | ||
| "@kampus/tailwind": "*", | ||
| "@kampus/ui-next": "*", |
There was a problem hiding this comment.
why UI package needs these APPs ?
Package should never need an App from the workspace
There was a problem hiding this comment.
the @kampus/kampus and @kampus/ui-next imports exist under apps/ui/ (see here).
these imports were working without issues with npm but they need to be defined as dependencies with pnpm as otherwise the imports will fail (due to how pnpm stores packages under node_modules)
There was a problem hiding this comment.
This is fine @Ketcap
apps/ui is our storybook application.
packages/ui is the kampus-ui package.
| "@opentelemetry/api": "1.4.1", | ||
| "@opentelemetry/core": "1.13.0", | ||
| "@opentelemetry/exporter-trace-otlp-grpc": "0.39.1", | ||
| "@opentelemetry/resources": "1.13.0", | ||
| "@opentelemetry/sdk-trace-base": "1.13.0", | ||
| "@opentelemetry/sdk-trace-node": "1.13.0", | ||
| "@opentelemetry/semantic-conventions": "1.13.0" |
There was a problem hiding this comment.
Any reasons ? Maybe we can document this.
There was a problem hiding this comment.
was getting the same error as this issue when building with pnpm: contentlayerdev/contentlayer#506
it can be a temporary solution until the main issue with the dependencies are resolved (assuming the version of the contentlayer is incremented on this repo as well)
| @@ -0,0 +1,9 @@ | |||
| import { withContentlayer } from "next-contentlayer"; | |||
There was a problem hiding this comment.
I don't think this should be here, this package should not relay on something it's not using.
There was a problem hiding this comment.
I added this one since the build was failing when building gql app since it depends on some files generated with contentlayer under sozluk-content package.
this of course didn't fix the issue and the actual solution was adding -r flag to pnpm run build command so that it starts building sozluk-content before building gql. will test removing this today.
There was a problem hiding this comment.
just removed this next-contentlayer package thing, and the build process still works properly with -r flag added to pnpm run build command, until this error.
this error is fixed by adding "noImplicitAny": false to tsconfig.json file, but don't know if this is wanted by the maintainers @Ketcap .
|
@mcanueste i am gonna take a look at this asap, sorry it took this long. |
Description
Please describe your changes. Be descriptive enough to reduce churn for review process.
Checklist
username#0001npx turbo runat the root of the repository, and build was successful.npm install --save-exact <package>so my package is pinned to a specific npm version. Leave empty if no package was installed. Leave empty if no package was installed with this PR.How were these changes tested?
Please describe the tests you did to test the changes you made. Please also specify your test configuration.
NOTE: I will fill out the checklist when the MR is ready. This MR is created for debugging pnpm builds
The build process fails here
Seems like
contentlayeris not generating files (or failing). Addednext-contentlayerfollowing the guide here in case it helps, but seems like it is not working as well.A github issue that might be related is here.