Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epic: switch to pnpm #502

Open
2 tasks
usirin opened this issue Jul 6, 2023 · 1 comment
Open
2 tasks

epic: switch to pnpm #502

usirin opened this issue Jul 6, 2023 · 1 comment
Assignees
Labels
CI/CD things related to continuous integration & deployment of the repository epic a big issue that tracks other issues, if you know jira, you know what epics are :D

Comments

@usirin
Copy link
Member

usirin commented Jul 6, 2023

What is this epic about?

We wanna switch to pnpm from npm for node package & workspace management.

Tasks for this epic

  • switch to pnpm tooling with pnpm-workspace.yml
  • add an .npmrc file to let us use workspaces without pnpm's workspace: pkg prefix
@usirin usirin added epic a big issue that tracks other issues, if you know jira, you know what epics are :D CI/CD things related to continuous integration & deployment of the repository labels Jul 6, 2023
mcanueste added a commit to mcanueste/monorepo that referenced this issue Jul 8, 2023
@mcanueste
Copy link
Contributor

mcanueste commented Jul 8, 2023

ben bakiyorum buna

Hi, I spent a lot of time on this task but can't really make it work as things keep breaking when using pnpm. I think there are many assumptions on npm usage with the software stack/versions used in this repository that when pnpm breaks those assumptions, everything else breaks as well. It doesn't also help that I am not really familiar with next.js, turborepo etc.

Unfortunately, I can't really spend more time on this task, so I think it would be better if someone else picks this task.

Current state of the changes I have made are available on this fork. Some discussions about the changes made are available on this PR. The latest error I get when I run pnpm turbo run build is

@kampus-apps/gql:build: node:internal/modules/cjs/loader:1080
@kampus-apps/gql:build:   throw err;
@kampus-apps/gql:build:   ^
@kampus-apps/gql:build:
@kampus-apps/gql:build: Error: Cannot find module '/home/mcst/projects/monorepo/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected][email protected][email protected]/node_modules/next/dist/bin/next'
@kampus-apps/gql:build:     at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
@kampus-apps/gql:build:     at Module._load (node:internal/modules/cjs/loader:922:27)
@kampus-apps/gql:build:     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
@kampus-apps/gql:build:     at node:internal/main/run_main_module:23:47 {
@kampus-apps/gql:build:   code: 'MODULE_NOT_FOUND',
@kampus-apps/gql:build:   requireStack: []
@kampus-apps/gql:build: }
@kampus-apps/gql:build:
@kampus-apps/gql:build: Node.js v18.16.1
@kampus-apps/gql:build:  ELIFECYCLE  Command failed with exit code 1.
@kampus-apps/gql:build: ERROR: command finished with error: command (/home/user/projects/monorepo/apps/gql) pnpm run build exited (1)

mcanueste added a commit to mcanueste/monorepo that referenced this issue Jul 8, 2023
mcanueste added a commit to mcanueste/monorepo that referenced this issue Jul 24, 2023
mcanueste added a commit to mcanueste/monorepo that referenced this issue Jul 24, 2023
mcanueste added a commit to mcanueste/monorepo that referenced this issue Jul 24, 2023
mcanueste added a commit to mcanueste/monorepo that referenced this issue Jul 24, 2023
mcanueste added a commit to mcanueste/monorepo that referenced this issue Jul 24, 2023
mcanueste added a commit to mcanueste/monorepo that referenced this issue Jul 24, 2023
mcanueste added a commit to mcanueste/monorepo that referenced this issue Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD things related to continuous integration & deployment of the repository epic a big issue that tracks other issues, if you know jira, you know what epics are :D
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants