🐛 Fix custom binds set as RW_PATHS #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RW_PATHS are meant for overlay dirs which go away after a reboot. Custom binds/binds are mounted under COS_PERSISTENT, so they persist after reboot AND are RW by default. This patch removes adding the custom binds into the RW_PATHS on the cos-layout file as that can lead to unintended consequences Signed-off-by: Itxaka <[email protected]>
✅ Deploy Preview for kairos-io canceled.
|
Signed-off-by: Itxaka <[email protected]>
|
This also sets the defaults for recovery to be sure that we have a proper cos-layout file AND prevents the custom layout for running on anything that its not active/passive |
|
Umm this still doesnt fix the bind mounts being set properly |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #944 +/- ##
=======================================
Coverage 22.79% 22.79%
=======================================
Files 22 22
Lines 1610 1610
=======================================
Hits 367 367
Misses 1179 1179
Partials 64 64 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mudler
reviewed
Feb 22, 2023
mudler
reviewed
Feb 22, 2023
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
This was referenced Feb 22, 2023
Signed-off-by: Itxaka <[email protected]>
mudler
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RW_PATHS are meant for overlay dirs which go away after a reboot. Custom binds/binds are mounted under COS_PERSISTENT, so they persist after reboot AND are RW by default.
This patch adds custom binds into the PERSISTENT_STATE_PATHS and ephemeral into RW_PATHS
Also stops adding custom values into the cos-layout.env file as they are not needed
Also removes the existing keys to re-add them with the new merged values, otherwise we could have duplicated keys, which should not matter as the last one wins, but still its ugly and could cause problems in the future.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #