Fix templateless vm clean #436
Conversation
…plumbingwg#431)" This reverts commit 1478ec9. Signed-off-by: Ram Lavi <[email protected]>
former fix [0] was not sufficient. Moving the check earlier in the webhoook handling. Signed-off-by: Ram Lavi <[email protected]>
RamLavi
force-pushed
the
fix_templateless_vm_clean
branch
from
3e2b11f
to
2ed7946
Compare
|
/cherry-pick release-0.44 |
|
@RamLavi: once the present PR merges, I will cherry-pick it on top of release-0.44 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@RamLavi: new pull request created: #438 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
PR #431 did not fully fix the issue of kubemacpool crashing when setting VM with nil template.
This PR reverts this PR and presents a better approach, ignoring the request at the beginning of the webhook Handle function.
What this PR does / why we need it:
Special notes for your reviewer:
Release note: