vm, webhook: Fix panic on templateless VM

former fix [0] was not sufficient. Moving the check earlier in the webhoook handling. Signed-off-by: Ram Lavi <[email protected]>
k8snetworkplumbingwg · Sep 8, 2024 · 3e2b11f · 3e2b11f
1 parent 246c3f2
commit 3e2b11f
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/pkg/webhook/virtualmachine/virtualmachine.go b/pkg/webhook/virtualmachine/virtualmachine.go
@@ -76,6 +76,12 @@ func (a *virtualMachineAnnotator) Handle(ctx context.Context, req admission.Requ
 
 	logger.V(1).Info("got a virtual machine event")
 
+	if virtualMachine.Spec.Template == nil {
+		const errMsg = "virtual machine template is nil, ignoring virtual machine"
+		logger.Info(errMsg)
+		return admission.Allowed(errMsg)
+	}
+
 	isNotDryRun := (req.DryRun == nil || *req.DryRun == false)
 	if req.AdmissionRequest.Operation == admissionv1.Create {
 		err = a.mutateCreateVirtualMachinesFn(virtualMachine, isNotDryRun, logger)