Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint to v1.56.2 #4078

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Feb 19, 2024

Description

https://github.com/golangci/golangci-lint/releases/tag/v1.56.0
https://github.com/golangci/golangci-lint/releases/tag/v1.56.1
https://github.com/golangci/golangci-lint/releases/tag/v1.56.2

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Copy link
Member Author

twz123 commented Feb 19, 2024

The new failing lint is correct: #4080.

@twz123 twz123 force-pushed the bump-golangci-lint branch from 071a7f5 to 90acacc Compare February 20, 2024 14:41
@twz123 twz123 marked this pull request as ready for review February 21, 2024 08:46
@twz123 twz123 requested a review from a team as a code owner February 21, 2024 08:46
@twz123 twz123 merged commit 1b39263 into k0sproject:main Feb 21, 2024
73 checks passed
@twz123 twz123 deleted the bump-golangci-lint branch February 21, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants